Skip to content
Snippets Groups Projects
Commit 6fc4ec5a authored by Tim Repke's avatar Tim Repke
Browse files

Merge branch 'master' into 'production'

fix item details endpoint

See merge request !35
parents b2b143bb f677df5a
No related branches found
No related tags found
1 merge request!35fix item details endpoint
Pipeline #1236 passed
from fastapi import APIRouter, Depends, HTTPException, status, Query from fastapi import APIRouter, Depends, HTTPException, status, Query
from nacsos_data.db.schemas import Project, ItemTypeLiteral, GenericItem, AcademicItem from nacsos_data.db.schemas import Project, ItemTypeLiteral, GenericItem, AcademicItem, ItemType
from nacsos_data.models.items import AnyItemModel, GenericItemModel, AcademicItemModel, AnyItemModelList from nacsos_data.models.items import AnyItemModel, GenericItemModel, AcademicItemModel, AnyItemModelList
from nacsos_data.models.items.twitter import TwitterItemModel from nacsos_data.models.items.twitter import TwitterItemModel
...@@ -71,10 +71,12 @@ async def get_detail_for_item(item_id: str, ...@@ -71,10 +71,12 @@ async def get_detail_for_item(item_id: str,
item_type = project.type item_type = project.type
result: AnyItemModel | None = None result: AnyItemModel | None = None
if item_type == 'basic': if item_type == 'generic':
result = await read_any_item_by_item_id(item_id=item_id, item_type=item_type, engine=db_engine) result = await read_any_item_by_item_id(item_id=item_id, item_type=item_type, engine=db_engine)
elif item_type == 'twitter': elif item_type == 'twitter':
result = await read_twitter_item_by_item_id(item_id=item_id, engine=db_engine) result = await read_twitter_item_by_item_id(item_id=item_id, engine=db_engine)
elif item_type == 'academic':
result = await read_any_item_by_item_id(item_id=item_id, item_type=ItemType.academic, engine=db_engine)
else: else:
raise HTTPException(status_code=status.HTTP_501_NOT_IMPLEMENTED, raise HTTPException(status_code=status.HTTP_501_NOT_IMPLEMENTED,
detail=f'Detail getter for {item_type} not implemented (yet).') detail=f'Detail getter for {item_type} not implemented (yet).')
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment