From 97c920223a3ca55201eacc42ec100d36ea588642 Mon Sep 17 00:00:00 2001 From: giannou <11047746+giannou@users.noreply.github.com> Date: Fri, 10 Apr 2020 12:56:25 +0200 Subject: [PATCH] update the slurmConfig setting to what the user chooses when prompted (it was being ignored before) --- scripts/start/readme.txt | 2 +- start.R | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/start/readme.txt b/scripts/start/readme.txt index b51f0d4..8e77fc3 100644 --- a/scripts/start/readme.txt +++ b/scripts/start/readme.txt @@ -2,7 +2,7 @@ Documentation of the new procedure of starting REMIND runs (DK, LB, January 2020 Why did we redesign the procedure? -The old code was spread across more files, the user needed to edit files in order to provide the SLURM options, and a substantial part of the code was run on the login node before finally submiting the job to SLURM. The new structure lets the user choose the SLURM options interactively when starting the runs. The amount of code that is executed on the login node was minimized. Most of the work load that is required to set up a run is included in the SLURM batch job. Finally, the code is strucutred more clearly and spread across less files. +The old code was spread across many files, the user needed to edit files in order to provide the SLURM options, and a substantial part of the code was run on the login node before finally submiting the job to SLURM. The new structure lets the user choose the SLURM options interactively when starting the runs. The amount of code that is executed on the login node was minimized. Most of the work load that is required to set up a run is included in the SLURM batch job. Finally, the code is strucutred more clearly and spread across less files. To start a run type in the main directory of REMIND: diff --git a/start.R b/start.R index c793f81..fff84bd 100755 --- a/start.R +++ b/start.R @@ -196,6 +196,7 @@ if ('--restart' %in% argv) { for (outputdir in outputdirs) { cat("Restarting",outputdir,"\n") load(paste0("output/",outputdir,"/config.Rdata")) # read config.Rdata from results folder + cfg$slurmConfig <- slurmConfig # update the slurmConfig setting to what the user just chose (it was being ignored before) submit(cfg, restart = TRUE) #cat(paste0("output/",outputdir,"/config.Rdata"),"\n") } -- GitLab